Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace of exceptions are not being logged #1974

Open
rksk opened this issue Nov 9, 2018 · 0 comments
Open

Stack trace of exceptions are not being logged #1974

rksk opened this issue Nov 9, 2018 · 0 comments

Comments

@rksk
Copy link
Contributor

rksk commented Nov 9, 2018

Description:
There are multiple places where we do not print the stack trace of exceptions in error logs. Because the following format is used to log errors. For example [1], [2]
log.error("msg" + e)

It will be very helpful to debug issues if we use the following way to log exceptions.
log.error("msg", e)

[1] https://github.com/wso2/carbon-identity-framework/blob/master/components/entitlement/org.wso2.carbon.identity.entitlement/src/main/java/org/wso2/carbon/identity/entitlement/pip/CarbonAttributeFinder.java#L209
[2] https://github.com/wso2/carbon-identity-framework/blob/master/components/carbon-authenticators/thrift-authenticator/org.wso2.carbon.identity.authenticator.thrift/src/main/java/org/wso2/carbon/identity/thrift/authentication/internal/ThriftAuthenticationServiceComponent.java#L187

nitram509 added a commit to nitram509/carbon-identity-framework that referenced this issue Oct 9, 2020
replace string concatenation with throwable parameter
see wso2#1974
pulasthi7 added a commit that referenced this issue Oct 11, 2020
…_are_not_being_logged

Fix: stack trace of exceptions are not being logged #1974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant