Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tika processing to to pass phpcs #3

Open
carl-alberto opened this issue Nov 8, 2019 · 0 comments
Open

Improve Tika processing to to pass phpcs #3

carl-alberto opened this issue Nov 8, 2019 · 0 comments
Milestone

Comments

@carl-alberto
Copy link
Member

// phpcs:disable -- Process handling by Tika
$process = proc_open( $command, $descriptorspec, $pipes );
$file_data = '';
while ( ! feof( $pipes[1] ) ) {
$file_data .= fgets( $pipes[1], 1024 );
}
fclose( $pipes[1] );
// phpcs:enable

$process = proc_open( $command, $descriptorspec, $pipes );

proc_open() found. PHP system calls are often disabled by server admins.

File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose()

@carl-alberto carl-alberto added this to the 1.0.5 milestone Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant