Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible S3 Compat. with DreamObject (and the like). #156

Open
jaswrks opened this issue May 20, 2014 · 16 comments
Open

Possible S3 Compat. with DreamObject (and the like). #156

jaswrks opened this issue May 20, 2014 · 16 comments

Comments

@jaswrks
Copy link
Contributor

jaswrks commented May 20, 2014

@clavaque writes...

https://websharks.zendesk.com/agent/#/tickets/2711 re. more CDN integrations with little work. He just hacked s2 to work with DreamObjects, successfully. He describes the hack in his last reply, and it's very simple. It looks like other services would be similar. I think you should take a serious look at this one, it may make it possible for us to add a bunch of services to the download protection, with very little effort.

Great! thank you :-) I will take a closer look at this soon. I've seen the AirFiles app on a Mac doing something similar. It seems that some of the cloud services are trying to make themselves S3-compatible to prevent the need for yet another new integration. Nice!

One consideration that we need to make, is with s2Member and Cloudfront. I will have to look closer at all of this first, but I suspect that services like DreamObjects are probably limited to the S3 portion of the integration only; i.e. this will probably not be compatible with the CloudFront integration at all.

@clavaque
Copy link
Contributor

Cool. :)

@jaswrks
Copy link
Contributor Author

jaswrks commented May 27, 2014

The my plan here (for the short term) is to add a new UI option called, "S3 Compatible Bucket" where we will accept a Bucket Name, Access Key, Secret Key; and a host name for the S3 Compatible Service of their choosing.

This won't be compatible (initially) with Cloudfront integration, but we can work on that in the future.

@clavaque
Copy link
Contributor

Okay.

@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 9, 2014

@clavaque Do you feel like working on this?

@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 9, 2014

@raamdev Based on my comment here; if you'd like to help by building the UI panel itself, I will come back in later and add the functionality that makes it work. Interested?

We really just need a clone of the S3 configuration panel in s2Member (same option fields in another panel); but stripped down without all of the extra documentation that is S3-specific. We'll also need to add one extra field to identify the API endpoint domain to use instead of the s3.amazonaws.com domain.

Possible title for the new option panel:
S3 Compatible Content Delivery (e.g. DreamObjects, etc.)

@clavaque
Copy link
Contributor

This will be and s2Member Pro feature.

@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 10, 2014

@raamdev If you work on this and you're not sure how to put it into the pro version; no worries. Just clone the one that exists in the framework (in the framework); and I will move it into the pro version before the release.

@clavaque
Copy link
Contributor

I guess he can look at how you did the WP Admin -> s2Member -> Restrictions -> Simultaneous Logins one.

@raamdev
Copy link
Contributor

raamdev commented Jun 11, 2014

Got it. I'll work on this later this week. Assigning this to myself.

@raamdev raamdev self-assigned this Jun 11, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 1, 2014

@raamdev I'm just reviewing this again. I know you are planning to come back around to this soon. If there are questions or problems please let me know. Thanks!

@raamdev
Copy link
Contributor

raamdev commented Jul 2, 2014

@jaswsinc Thanks for checking in. Yes, I haven't forgotten about this and I still have it on my TODO list.

I see that it's not longer on a Milestone. Would you like to update here again when you assign it to a milestone so that I can prioritize it? Right now I'm focusing on getting the next Quick Cache release out.

@jaswrks jaswrks added this to the Future Release milestone Jul 2, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 2, 2014

@raamdev Sounds good.

Would you like to update here again when you assign it to a milestone so that I can prioritize it? Right now I'm focusing on getting the next Quick Cache release out.

I will put this on the "Future Release" milestone. Once you add the panel I will need to come back and add the functionality for it in code; so that will give us both some time.

@raamdev
Copy link
Contributor

raamdev commented Aug 9, 2014

@jaswsinc A new options panel, based on the Amazon S3 options panel, has been added. I renamed any relevant variables to use amazon-s3-comp and amazon_s3_comp. I also removed the documentation while updating the documentation underneath the input boxes. Finally, I added a new API Endpoint field as you requested.

Note that since the new variables don't yet exist, you'll see PHP Undefined Notices when you load this panel as it stands now.

2014-08-09_16-22-49

I'm reassigning this to you. Feel free to reassign to me if there's something you need me to change or work on here.

@raamdev raamdev assigned jaswrks and unassigned raamdev Aug 9, 2014
@raamdev
Copy link
Contributor

raamdev commented Aug 9, 2014

I forgot to mention that this code was committed and pushed to the feature/156 branch.

@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 10, 2014

Perfect! Thanks @raamdev
~ I will leave this open and continue the work in this branch.

@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 13, 2014

Punting this to the next release milestone.

@jaswrks jaswrks modified the milestones: Next Release, Future Release Aug 13, 2014
@jaswrks jaswrks modified the milestones: Next Release, v140909 Sep 9, 2014
@jaswrks jaswrks added this to the Next Release milestone Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants