Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade links are not displayed #907

Merged
merged 23 commits into from
Dec 16, 2024
Merged

Conversation

BrunoPavlinic98
Copy link
Contributor

closes #903

@BrunoPavlinic98
Copy link
Contributor Author

@Terminator-Barbapapa Can you please test this?

Copy link
Contributor

@Terminator-Barbapapa Terminator-Barbapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this for the four possible scenario's:

1. Only the Professional extension is installed and activated:

Column 1: Show Professional extension features + Display 'Currently installed'.
Column 2: Show Bundle features + Display 'Upgrade now' button with personal upgrade link.

2. Only the Premium Templates extension is installed and activated:

Column 1: Show Premium Templates extension features + Display 'Currently installed'.
Column 2: Show Bundle features + Display 'Upgrade now' button with personal upgrade link.

3. Both the Professional and Premium Templates extensions are installed and activated:

Column 1: Show Professional extension features.
Column 2: Show Bundle features + Display 'Currently installed'.

4. Neither the Professional and Premium Templates extensions are installed and activated:

Column 1: Show Professional extension features + Display 'Buy now' button with a link to the product page (including UTM parameters).
Column 2: Show Bundle features + Display 'Buy now' button with a link to the product page (including UTM parameters).

Here is what I found:

  • Scenario 1: The link for the Bundle goes to the product page instead of providing a personal upgrade link for the customer.
  • Scenario 2: The link for the Bundle goes to the product page instead of providing a personal upgrade link for the customer.
  • Scenario 3: The column with Professional features is not showing. The 'Upgrade now' button for the Bundle is still visible. This should become the 'Currently installed' message.
  • Scenario 4: Correct.

@BrunoPavlinic98
Copy link
Contributor Author

@Terminator-Barbapapa Since the personal upgrade link consists of edd_license_key and download_id, I was wondering if download_id is hardcoded somewhere and if it is connected to particular products (plugins) we are offering?

@BrunoPavlinic98
Copy link
Contributor Author

@Terminator-Barbapapa I think I covered all the cases now. I have added some new piece of code that should be (in my opinion) easier to read and debug.

includes/Settings/SettingsUpgrade.php Outdated Show resolved Hide resolved
includes/Settings/SettingsUpgrade.php Outdated Show resolved Hide resolved
includes/Settings/SettingsUpgrade.php Outdated Show resolved Hide resolved
Copy link
Contributor

@Terminator-Barbapapa Terminator-Barbapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@alexmigf alexmigf merged commit e152c49 into main Dec 16, 2024
7 checks passed
@alexmigf alexmigf deleted the 903-upgrade-links-not-displayed branch December 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade links are not displayed
3 participants