Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the setup Wizard #895

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

BrunoPavlinic98
Copy link
Contributor

closes #857

@BrunoPavlinic98
Copy link
Contributor Author

@Terminator-Barbapapa Here is the initial version. I think this is quite of a progress in terms of design. On the final step, the user gets redirected to the upgrade page after he clicks the "Finish" button.

@Terminator-Barbapapa
Copy link
Contributor

I think in the case of a multi checkbox option, replacing each checkbox with a toggle switch doesn't work well.

Scherm­afbeelding 2024-11-04 om 10 56 42

Let's only use a toggle switch for options that used to be a single checkbox. In the case of the 'Attach to' option I think we might want to move to an enhanced select option like we do for instance with the 'Disable for' setting. As you can see in my case I have a lot of potential emails the invoice can be attached to, creating a very long list.

@BrunoPavlinic98
Copy link
Contributor Author

@Terminator-Barbapapa I have added enhanced select.

I have deliberately added the following lines:

<link rel="stylesheet" href="<?php echo WC()->plugin_url() . '/assets/css/admin.css'; ?>">
<script src="<?php echo WC()->plugin_url() . '/assets/js/select2/select2.full.min.js'; ?>"></script>

because for some reason, wp_enqueue_style, wp_register_script, and wp_enqueue_style did not work for me.

With that, I am not sure why JS minifying is not working, I will try to reboot it.

@BrunoPavlinic98
Copy link
Contributor Author

@Terminator-Barbapapa I have added enhanced select.

I have deliberately added the following lines:

<link rel="stylesheet" href="<?php echo WC()->plugin_url() . '/assets/css/admin.css'; ?>">
<script src="<?php echo WC()->plugin_url() . '/assets/js/select2/select2.full.min.js'; ?>"></script>

because for some reason, wp_enqueue_style, wp_register_script, and wp_enqueue_style did not work for me.

With that, I am not sure why JS minifying is not working, I will try to reboot it.

@Terminator-Barbapapa Minifying is OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the setup Wizard
3 participants