Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fix imgui libraries not being published #7575

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[build] Fix imgui libraries not being published #7575

merged 1 commit into from
Dec 24, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Dec 22, 2024 •
edited
Loading

Fixes mismatched library name between imgui_suite's build.gradle and publish.gradle by renaming the library to imguiSuite.
Fixes #7241.

@github-actions github-actions bot added component: cscore CameraServer library component: glass Glass app and backend component: outlineviewer OutlineViewer app component: datalogtool DataLog Tool component: sysid SysId app component: teamnumbersetter roboRIO Team Number Setter labels Dec 22, 2024
@Gold856 Gold856 marked this pull request as ready for review December 22, 2024 06:02
@Gold856 Gold856 requested review from a team as code owners December 22, 2024 06:02
@PeterJohnson
Copy link
Member

I don't quite understand how renaming the source set fixes this?

@Gold856
Copy link
Contributor Author

Gold856 commented Dec 23, 2024

In thirdparty/imgui_suite/publish.gradle, the zip task is looking for imguiSuite, but that doesn't exist, since the library name is actually imgui. So by renaming the library to imguiSuite (which is the more accurate name), the zip task actually picks up the libraries.

@PeterJohnson PeterJohnson merged commit b670a59 into wpilibsuite:main Dec 24, 2024
43 checks passed
@Gold856 Gold856 deleted the fix-imgui-publishing branch December 24, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
component: cscore CameraServer library component: datalogtool DataLog Tool component: glass Glass app and backend component: outlineviewer OutlineViewer app component: sysid SysId app component: teamnumbersetter roboRIO Team Number Setter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

imgui libraries are not published
2 participants
@Gold856 @PeterJohnson