Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpilib] Deprecate Resource #6952

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[wpilib] Deprecate Resource #6952

merged 1 commit into from
Aug 12, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Aug 12, 2024

No description provided.

@Gold856 Gold856 requested a review from a team as a code owner August 12, 2024 06:08
rzblue
rzblue requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@rzblue rzblue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add @deprecated in the doc comments, could suggest the HandleResource classes as a replacement for c++

@Gold856 Gold856 force-pushed the deprecate-resource branch from 3cb7394 to 092149d Compare August 12, 2024 06:17
rzblue
rzblue previously approved these changes Aug 12, 2024
View reviewed changes
@Gold856 Gold856 force-pushed the deprecate-resource branch from 092149d to cce0eae Compare August 12, 2024 07:18
rzblue
rzblue requested changes Aug 12, 2024
View reviewed changes
wpilibc/src/main/native/cpp/Resource.cpp Outdated Show resolved Hide resolved
@Gold856 Gold856 force-pushed the deprecate-resource branch from cce0eae to 6e7836a Compare August 12, 2024 08:41
@PeterJohnson PeterJohnson merged commit 05e955f into wpilibsuite:main Aug 12, 2024
33 checks passed
@Gold856 Gold856 deleted the deprecate-resource branch August 12, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty approved these changes

@rzblue rzblue rzblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gold856 @rzblue @spacey-sooty @PeterJohnson