Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Add shortcode for Google Map #23

Open
jimmyandrade opened this issue Jun 20, 2015 · 2 comments
Open

Add shortcode for Google Map #23

jimmyandrade opened this issue Jun 20, 2015 · 2 comments

Comments

@jimmyandrade
Copy link

As we can see at:
https://github.com/jimmyandrade/shortcake-bakery/blob/master/inc/shortcodes/class-google-map.php

Code uses build_map_link() and urlencode_address() to generate Google map urls.

@davisshaver
Copy link
Member

@jimmyandrade This looks good/useful (and sorry for the Github deluge this morning).

We are currently working for the v0.1.0 release. If you'd like to get this in, we'd probably need a pull request with test coverage. We'll also help with code review and adding documentation. Otherwise we'll hold this issue in the backlog until we can work it into project planning.

@jimmyandrade
Copy link
Author

@davisshaver No problem. I stayed a long time without being able to discuss about these issues. I'd like some help to create the tests, so maybe we could bring the Google Maps in the next release...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants