Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

allow bypassing whitelist for iframe and script shortcodes #175

Open
montchr opened this issue Apr 6, 2016 · 3 comments
Open

allow bypassing whitelist for iframe and script shortcodes #175

montchr opened this issue Apr 6, 2016 · 3 comments

Comments

@montchr
Copy link
Contributor

montchr commented Apr 6, 2016

Users of the plugin should be given the option to bypass the domain whitelists for the Iframe and Script shortcodes.

@danielbachhuber
Copy link
Contributor

Why?

@montchr
Copy link
Contributor Author

montchr commented Apr 6, 2016

Oftentimes our reporters would like to embed videos from various local news stations etc., which oftentimes use unpredictable domains for video streaming. In a breaking news situation, a video embed being blocked by the whitelist check gets pretty frustrating. Rather than having the editorial group request a domain added to the whitelist every single time, it would be easier to bypass the whitelist feature entirely.

@goldenapples
Copy link
Contributor

@montchr You might want to look into something like https://github.com/humanmade/protected-embeds for that purpose. We use the Shortcake Bakery "Insert Embed code" UI for reporters to paste embed codes into and Shortcake Bakery's reversal process to replace embed codes with a match where available, but then use the shortcake_bakery_embed_reversal hook here to create a protected embed post if the script entered doesn't match a post element or a whitelisted iframe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants