Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Fix attachment field listener functions for compatability with Shortcake 0.7.x #75

Open
goldenapples opened this issue Jan 26, 2017 · 0 comments · May be fixed by #79
Open

Fix attachment field listener functions for compatability with Shortcake 0.7.x #75

goldenapples opened this issue Jan 26, 2017 · 0 comments · May be fixed by #79

Comments

@goldenapples
Copy link
Contributor

goldenapples commented Jan 26, 2017 •
edited
Loading

In the image-shortcake-admin js file, we're calling the method editAttributeFieldAttachment.getFromCache object from Shortcake, which was removed from Shortcake in wp-shortcake/shortcake#508.

To avoid throwing errors, this should be updated to use the public methods exposed.
@goldenapples goldenapples mentioned this issue Jan 26, 2017
Closed
jeremyfelt added a commit to washingtonstateuniversity/image-shortcake that referenced this issue May 22, 2017
@jeremyfelt
Hotfix: Get attachment attributes directly
a280168 
The `getFromCache()` method was deprecated in Shortcode UI via
wp-shortcake/shortcake#508

This should work as a band-aid until fixed upstream via
wp-shortcake#75
montchr pushed a commit to spiritedmedia/image-shortcake that referenced this issue Aug 2, 2017
fix img shortcode editing
fb9e914 
https://github.com/spiritedmedia/spiritedmedia/issues/2115
wp-shortcake#75
washingtonstateuniversity@a280168
@goldenapples goldenapples linked a pull request Sep 7, 2017 that will close this issue
Open
@montchr montchr mentioned this issue Sep 8, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix call to removed getFromCache function in Shortcake wp-shortcake/image-shortcake
1 participant
@goldenapples