Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test on lcp feature #106

Open
Mai-Saad opened this issue Jun 6, 2024 · 0 comments
Open

Smoke test on lcp feature #106

Mai-Saad opened this issue Jun 6, 2024 · 0 comments

Comments

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Jun 6, 2024

Is your feature request related to a problem? Please describe.
Currently, we aren't doing the check for preload markup for all the templates at lcp which results in hidden 404 after markup is applied and sometimes fatal error

Describe the solution you'd like
For all templates, we need:
Before all => visit all lcp templates so lcp/atf is created
Given cache is cleared
When template x is visited
And hard refresh the page // this step as sometimes markup changes when we have timestamp cache at the page due to a special char handle
then no error in debug.log
And no console error

Additional context
Possible enhancements:

  1. we can add as well that no visual regression or it will take much time
  2. we can check the markup is as expected or if it's already at integration tests (for all templates) then we can skip here
  3. we can check that fetchpriority='high' is added to image tag (this exists in some templates so may be better be other test) ==> as per LCP test for checking fetchpriority fails consistently #98 it's just now for lcp_regular_img_template so we can add on that other templates containing img tag either in picture or not
  4. We can check what other useful scenarios to pick from here Visual regression & error logs testing for 3.16 templates #53 (comment)

@MathieuLamiot @jeawhanlee what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant