You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually the deliver_backup is used inside the Exporter class.
May I suggest to move it within an own class, so we can use it without need to instanziate the Exporter?
This because the method is called only within the FileDownloader.
If it's possible I suggest something like this
SearchReplaceModal => A class that implements the show_changes and show_modal separating data from presentation.
Gizipper => A class to zip files.
FileDownloader => DownloadHandler
- Take the request for a file, get a BackupDeliver instance and call deliver to perform the action.
- Make method trim_search_results a generic function.
- Remove the show_changes and show_modal and hook the class somewhere else.
-- The modal is used in different context, not only when we want to download a file but even in
dry mode.
BackupDeliver => Actually will be the deliver_backup logic as a class.
- take an instance of Gzipper to gzip the file if needed
The text was updated successfully, but these errors were encountered:
Actually the
deliver_backup
is used inside theExporter
class.May I suggest to move it within an own class, so we can use it without need to instanziate the
Exporter
?This because the method is called only within the
FileDownloader
.If it's possible I suggest something like this
SearchReplaceModal => A class that implements the
show_changes
andshow_modal
separating data from presentation.Gizipper => A class to zip files.
FileDownloader => DownloadHandler
- Take the request for a file, get a
BackupDeliver
instance and calldeliver
to perform the action.- Make method
trim_search_results
a generic function.- Remove the
show_changes
andshow_modal
and hook the class somewhere else.-- The modal is used in different context, not only when we want to download a file but even in
dry mode.
BackupDeliver => Actually will be the
deliver_backup
logic as a class.- take an instance of Gzipper to gzip the file if needed
The text was updated successfully, but these errors were encountered: