Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery Backup #111

Open
widoz opened this issue Dec 19, 2017 · 0 comments
Open

Delivery Backup #111

widoz opened this issue Dec 19, 2017 · 0 comments

Comments

@widoz
Copy link
Contributor

widoz commented Dec 19, 2017

Actually the deliver_backup  is used inside the Exporter class.

May I suggest to move it within an own class, so we can use it without need to instanziate the Exporter?

This because the method is called only within the FileDownloader.
If it's possible I suggest something like this

SearchReplaceModal => A class that implements the show_changes and show_modal separating data from presentation.

Gizipper => A class to zip files.

FileDownloader => DownloadHandler
- Take the request for a file, get a BackupDeliver instance and call deliver to perform the action.
- Make method trim_search_results a generic function.
- Remove the show_changes and show_modal and hook the class somewhere else.
-- The modal is used in different context, not only when we want to download a file but even in
dry mode.

BackupDeliver => Actually will be the deliver_backup logic as a class.
- take an instance of Gzipper to gzip the file if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant