Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Product" interfaces shared fields fix #901

Conversation

kidunot89
Copy link
Member

…re optimal schema shape

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Adds Product interface as parent interface to the following interfaces:
    • InventoriedProduct
    • ProductWithPricing
    • ProductWIthVariations
    • DownloadableProduct
    • ProductWithDimensions
    • ProductWithAttributes
    • ProductUnion

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

@kidunot89 kidunot89 marked this pull request as ready for review October 29, 2024 19:55
@kidunot89 kidunot89 merged commit 22b03e4 into wp-graphql:develop Nov 6, 2024
15 checks passed
@kidunot89 kidunot89 deleted the fix/product-interface-inconsistencies-fix branch November 6, 2024 16:35
@kidunot89 kidunot89 added the bugfix Implements bugfix label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants