Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build step for wp-cli/wp-cli-shim #592

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Oct 27, 2023

Assumes the existence of a new wp-cli/phar repository with a composer.json such as this one:

{
	"name": "wp-cli/wp-cli-shim",
	"description": "Composer-based WP-CLI Phar",
	"license": ["MIT"],
	"require": {
		"php": ">=5.6"
	},
	"conflict": {
		"wp-cli/wp-cli" : "*"
	},
	"bin": ["wp-cli.phar"]
}

And I think that's all that's needed.

To-do:

  • Add hashes and/or signature for verification
  • Maybe rename to wp-cli/wp-cli-shim or something

Fixes #134
Fixes wp-cli/ideas#145

@swissspidy swissspidy requested a review from a team as a code owner October 27, 2023 11:59
@danielbachhuber
Copy link
Member

@szepeviktor What do you think of this? Does it solve your needs?

@szepeviktor
Copy link
Contributor

szepeviktor commented Nov 4, 2023

Everything from Pascal gets the Seal of Approval from me.

image

.github/workflows/deployment.yml Outdated Show resolved Hide resolved
.github/workflows/deployment.yml Outdated Show resolved Hide resolved
@schlessera
Copy link
Member

@swissspidy The repository was created: https://github.com/wp-cli/wp-cli-shim

@swissspidy
Copy link
Member Author

@schlessera Thanks! Can you add me to the repo so I can add an initial composer.json file?

@swissspidy swissspidy changed the title Add build step for wp-cli/phar Add build step for wp-cli/wp-cli-shim Nov 10, 2023
@schlessera
Copy link
Member

@swissspidy Done.

@swissspidy
Copy link
Member Author

@schlessera OK so I pushed a branch intending to create a PR but because it was the first branch that became the default 🤦

https://github.com/wp-cli/wp-cli-shim

Can you make main the default, remove add-v0 and make any other changes as you see fit?

@swissspidy
Copy link
Member Author

@schlessera OK, so now I suppose what's left is making sure that the ACTIONS_BOT token has access to the new repo, then it should just work.

Once it does, we can tag what's currently in the repo with v2.9.0, afterwards there will be nightly updates people can use with dev-main.

Not sure if we need branch-alias there as well, that would probably complicate things.

@swissspidy
Copy link
Member Author

@schlessera wanna give this a try for next release?

uses: ad-m/github-push-action@master
with:
github_token: ${{ secrets.ACTIONS_BOT }}
branch: gh-pages
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branch: gh-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a wp-cli-shim Distribute a single PHAR file as composer package
4 participants