Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/38: trim filename size if it exceeds 99 bytes #92

Closed
wants to merge 7,390 commits into from
Closed

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Oct 18, 2021

Resolves #38

This fix trims the title if the size exceeds 99 bytes.

frankiejarrett and others added 30 commits February 24, 2017 22:57
Process `--activate` flag on `language install` even if already installed
Actually return `false` when `$widget` is empty
Adapt license header so GitHub picks it up
```
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing mustangostang/spyc (0.6.1)
  - Installing mustangostang/spyc (0.6.2)
    Downloading: 100%

  - Removing phpunit/php-timer (1.0.8)
  - Installing phpunit/php-timer (1.0.9)
    Downloading: 100%

Writing lock file
Generating autoload files
```
Before:
```
require:
  - file1.php  - file2.php
```

After:
```
require:
  - file1.php
  - file2.php
```
Update Composer dependencies (2/27/2017)
Add missing line break in FeatureContext.php
Introduce `WP_CLI\Utils\basename()` for locale-independent basename()
Abstract `wp import` to a separate wp-cli/import-command package
Per the function comment "Environment values permit specific binaries to be indicated". Currently not possible as PHP_BINARY ***always*** present as defined constant (which can NEVER be overridden unless one uses runkit_extension; dated, not supported)
Like with other commands, info, update, run command, utilize WP_CLI::get_php_binary() in lieu of fixed PHP_BINARY constant.
Fix allowing env. values to permit specific binary
Update tests for WordPress 4.7.3
Abstract `wp db *` to wp-cli/db-command
This prevents adding Composer dependencies with known security vulnerabilities.

Resolves #3842
…sories` package.

Note: This commit includes additional changes becauase Composer has changed the timestamp format for the lock file.
/**
* Remove the extra bytes from the sitename.
*/
$sitename = substr( $sitename, 0, ( $sitename_size - $extra_bytes ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using strlen and substr on multibyte strings will lead to corrupted characters, so I assume this will currently not work for titles with multibyte characters in the wrong position.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the multibyte versions of the string operations if they are available.

@danielbachhuber
Copy link
Member

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/eee05cd5845f51c91a775b7dfc5b6d2a in case this PR is auto-closed or broken in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export can fail to create because generated filename is too long.