Replace boolean value of config variables to literal string when showing to the user #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Can I get a review on this PR? @danielbachhuber |
|
@imrraaj, can this be tested with the behat feature tests to cover the various types of truthy/falsy values that might be used in wp-config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes following issue
I refactored the code to return the string representation of a boolean value (i.e., 'true' or 'false'), which is easier to display to the user. Previously, when the variable's value was true, it would render as '1', and blank when false. Using strings allows us to provide clearer guidance to the user regarding which value is true and which is false.