This repository has been archived by the owner on May 23, 2023. It is now read-only.
Negative test for a reentrant attack on the core relayer forward mechanism #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derpy-duck
approved these changes
Feb 10, 2023
|
Ah, I fear github didn't update the target branch for this pull request adequately 😅. I'll merge that branch into #81. |
scnale
added a commit
that referenced
this pull request
Feb 10, 2023
…anism (#83) * Modifies the relayer simulation to be easier to use in negative tests. * Adds negative test for a reentrancy attack on the forward mechanism. * `forge fmt` run.
derpy-duck
pushed a commit
that referenced
this pull request
Feb 14, 2023
…anism (#83) * Modifies the relayer simulation to be easier to use in negative tests. * Adds negative test for a reentrancy attack on the forward mechanism. * `forge fmt` run.
scnale
added a commit
that referenced
this pull request
Feb 14, 2023
…anism (#83) * Modifies the relayer simulation to be easier to use in negative tests. * Adds negative test for a reentrancy attack on the forward mechanism. * `forge fmt` run.
chase-45
pushed a commit
that referenced
this pull request
Feb 14, 2023
…anism (#83) * Modifies the relayer simulation to be easier to use in negative tests. * Adds negative test for a reentrancy attack on the forward mechanism. * `forge fmt` run.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #82. I thought that the modification to the
genericRelayer()function that simulates the relaying there was enough, but I still needed a way to conditionally invoke the mechanism without it failing and had to do further adjustments. In this way, the relayer can be simulated if the attack is successful, ensuring the test fails in that case.To test that the test does fail when the attack is successful you can comment these and this lines.