Remove the legacy contract and integrate the batching one #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
force-pushed
the
wip/ara/legacy-removal
branch
2 times, most recently
from
e7fb2e0 to
c2a7cdd
Compare
iamrecursion
had a problem deploying
to
stage-manual
GitHub Actions
Failure
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## batching/main #386 +/- ##
=================================================
+ Coverage 42.36% 43.12% +0.75%
=================================================
Files 30 29 -1
Lines 6798 7217 +419
=================================================
+ Hits 2880 3112 +232
- Misses 3918 4105 +187
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
iamrecursion
force-pushed
the
wip/ara/legacy-removal
branch
from
c2a7cdd to
fa8dc6c
Compare
iamrecursion
had a problem deploying
to
stage-manual
GitHub Actions
Failure
kustosz
approved these changes
Feb 13, 2023
This commit removes any use of the legacy contract from the codebase. This means that, while the code still exists due to some dependencies, it is no longer used. The batching contract is no-longer gated behind a feature flag. It is now fully integrated with the batching contract on chain, as well as the prover service used to generate proofs for verification on chain. These interactions are tested, and while multiple components are mocked the signup sequencer portion of the code is as it should be with the real external dependencies.
iamrecursion
force-pushed
the
wip/ara/legacy-removal
branch
from
fa8dc6c to
7a0616e
Compare
iamrecursion
had a problem deploying
to
stage-manual
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am so sorry for the size of this PR, but most of that horrendous line count is the new compiled contracts required for testing. It's big regardless, though.
This PR removes any use of the legacy contract from the codebase. This means that, while the code still exists due to some dependencies, it is no longer used. The batching contract is no-longer gated behind a feature flag.
It is now fully integrated with the batching contract on chain, as well as the prover service used to generate proofs for verification on chain. These interactions are tested, and while multiple components are mocked the signup sequencer portion of the code is as it should be with the real external dependencies.
Note that running the tests on macOS may trigger firewall protections that you need to disable. This depends on your macOS version.
Closes #259