Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degurba Example #29

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Degurba Example #29

wants to merge 36 commits into from

Conversation

elbeejay
Copy link
Contributor

@elbeejay elbeejay commented Mar 23, 2024

Build this PR off of #26 (so the long list of commits will go away once that's merged).

Trying to create an example notebook to help answer #6. Started with the existing "Implementation" notebook, URB_DECAT_B_ExploringGHSSMODcode.ipynb and tried to create a reproducible example.

The new example notebook uses pooch to fetch and cache the data used for the notebook in an effort to avoid adding more "sample data" to the repository. It wasn't clear to me where the existing notebook's data came from, so I tried to find similar data and setup pooch to retrieve that.

Unfortunately, for me the notebook hangs on the calculateDegurba() method call; @bpstewar or @andresfchamorro if either of you have any intuition as to why this might be the case I'm all ears.

I'm not 100% sure I'm pulling the right raster data to begin with, so knowing if the data I've set the notebook to grab is correct would be a good start. From there I'm not sure if it is getting stuck because it's trying to operate over a large raster and my computer has limited memory or what. Any help is appreciated, thanks!

elbeejay and others added 30 commits February 27, 2024 20:27
@elbeejay elbeejay requested a review from g4brielvs June 13, 2024 02:43
@g4brielvs g4brielvs added the enhancement New feature or request label Jun 17, 2024
@elbeejay
Copy link
Contributor Author

The new example I've tried to add to test/verify this functionality is at "notebooks/Tutorials/Degurba_Example.ipynb" on the feature branch associated with this pull request. Any help/thoughts/guidance on this function is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants