Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages update #92

Merged
merged 13 commits into from
Dec 2, 2024
Merged

Pages update #92

merged 13 commits into from
Dec 2, 2024

Conversation

Gabe-Levin
Copy link
Collaborator

@Gabe-Levin Gabe-Levin commented Nov 20, 2024

Merging latest changes and fixing #90

bpstewar and others added 7 commits November 15, 2024 08:50
* Update adding staging mechanism

* Add CD pipeline

* Solve f-string matching

* Update event to push on main

* Add dev CD

* Remove npm and node specific jobs

* Update variables

* Update environment

* Update role

* Remove cdk bootstrap

* Add working directory for cdk deployment

* Add cdk requirements

* Update cdk requirements

* Update deployment variables

* Refactor deployment tooling (#85)

* Migrate to reusable workflow

* Add tooling for PR preview URL

* Add runs-on

* Pre-commit

* Refactor triggers

* Bump version

* Add permissions

* Fix working dir

* Fix URL output

* Fix comment find

* Add tooling to tear down PR preview

* Fix commenting

* Fix

* Run tests on all pushes

* Refactor

* Fix

* Expand events

* Fix destroy

* Prevent unnecessary deployments

* Pass in PR number

* Prevent testing on closed PRs

* Refactor

* Mv to workflows

* Fix destroy

* Rework trigger

* Refine

* Rm old needs

* Rework trigger

* Try fix if condition

* Mv deployment trigger back to ci.yml

* Rework triggers

* Rename jobs

* Set concurrency to stage

* Only trigger on pushes to main

---------

Co-authored-by: Anthony Lukach <[email protected]>
@Gabe-Levin Gabe-Levin temporarily deployed to Space2Stats API Dev November 20, 2024 14:16 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 20, 2024

PR Deployment Details:
🚀 PR deployed to https://pl6prmd2y0.execute-api.us-east-1.amazonaws.com/

@Gabe-Levin Gabe-Levin requested a review from bpstewar November 20, 2024 14:44
@andresfchamorro
Copy link
Collaborator

Small changes to improve docs and build workflow

  • Changed structure of docs. Root file is readme.md and every file needs to be nested within docs (for sphinx to work).
  • Removed sphinx.ext.autodoc, but kept sphinx.ext.napoleon and sphinxcontrib.apidoc extensions to build rst file (docstrings).
  • Edited docstring from lib.py
  • Re-ran notebooks and added folium maps
  • Moved notebooks/user-docs to docs/user-docs. This makes it easier to build them without using symbolic links which don't work on windows.
  • Changed github action to deploy docs (will be tested once this PR is merged)
  • Added jupyter-book to .toml dependencies
  • Markdown changes to improve figure captions
  • New instructions for how to build docs locally and make changes in readme:

Environment Setup

To install the package and docs dependencies:

conda create -n book python=3.11
conda activate book
pip install poetry
cd space2stats_api/src
poetry install --with docs # Installs space2stats, dependencies and jupyter-book
pip install folium matplotlib mapclassify # for additional notebook visualizations

To build the documentation locally, run the following command:

sphinx-build docs _build/html -b html

Contributing

A Github Action is used to automatically build and deploy the documentation to Github Pages. To contribute to the documentation, please follow the steps below:

  1. Create a new branch from the latest main.

    git checkout -b new_docs
  2. Make changes to the documentation, e.g: markdown files, and table of contents (docs/_toc.yml).

  3. Build the documentation locally to ensure it renders correctly.

  4. Commit, push the changes to your branch and create a pull request.

    git add .
    git commit -m "Update documentation"
    git push origin new_docs

The site will be updated automatically once the branch is merged to main.

@andresfchamorro andresfchamorro merged commit 896f306 into main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants