Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/case sensitivity #101

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Bug/case sensitivity #101

merged 2 commits into from
Dec 11, 2024

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Transform column names to lowercase when inspecting metadata for validation and to ingest actual data
  • Add test to cover case sensitivity

How to test it

  • Run unit tests, which include a capitalized column test
  • Re-run ingestion job that identified the bug @bpstewar

Other notes

@zacdezgeo
Add test to reproduce error
ae2718d
@zacdezgeo
Use lower case for column names
c12af49 
Ingesting and validating column names is all done in lowercase which includes STAC metadata. Updated test to query 'hex_id' and not 'Hex_Id'.
@zacdezgeo zacdezgeo added the bug Something isn't working label Dec 10, 2024
@zacdezgeo zacdezgeo requested a review from alukach December 10, 2024 20:04
@zacdezgeo zacdezgeo self-assigned this Dec 10, 2024
@zacdezgeo zacdezgeo temporarily deployed to Space2Stats API Dev December 10, 2024 20:07 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

PR Deployment Details:
🚀 PR deployed to https://poxq8t3sia.execute-api.us-east-1.amazonaws.com/

@zacdezgeo zacdezgeo merged commit be2ea27 into main Dec 11, 2024
3 checks passed
@zacdezgeo zacdezgeo deleted the bug/case-sensitivity branch December 11, 2024 21:05
@zacdezgeo zacdezgeo temporarily deployed to Space2Stats API Dev December 11, 2024 21:05 — with GitHub Actions Inactive
@zacdezgeo zacdezgeo temporarily deployed to Space2Stats API Dev December 11, 2024 21:07 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alukach alukach alukach approved these changes

Assignees

@zacdezgeo zacdezgeo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Case sensitivity for columns names can cause errors during ingest process
2 participants
@zacdezgeo @alukach