From 45db4d6502d5528b47cc76df37a08cd0c9c2c4f4 Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Thu, 15 Sep 2022 19:38:40 +0000 Subject: [PATCH] Update virtual_person_id type to uint64. Currently the population_offset and total_population in VirtualPersonPool are uint64, while virtual_person_id in VirtualPersonActivity is int64. This could cause an issue when the range covered by virtual person pools is out of range of int64. This is a safe change per https://developers.google.com/protocol-buffers/docs/proto#updating --- src/main/proto/wfa/virtual_people/common/label.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/proto/wfa/virtual_people/common/label.proto b/src/main/proto/wfa/virtual_people/common/label.proto index 70ab88b..1b7acf7 100644 --- a/src/main/proto/wfa/virtual_people/common/label.proto +++ b/src/main/proto/wfa/virtual_people/common/label.proto @@ -56,7 +56,7 @@ message IndependentQuantumLabels { message VirtualPersonActivity { // If virtual_person_id is not set, then this is only for counting // impressions by labels, and can be ignored for reach purpose. - optional int64 virtual_person_id = 1; + optional uint64 virtual_person_id = 1; oneof person_label { // Quantum label. This is only for debugging purposes.