Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobufs do not follow proto3 conventions w.r.t. presence #61

Open
SanjayVas opened this issue Aug 30, 2023 · 0 comments
Open

Protobufs do not follow proto3 conventions w.r.t. presence #61

SanjayVas opened this issue Aug 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@SanjayVas
Copy link
Member

proto3 scalar fields have no distinction by default between not being present and being set to the field's default value. The optional keyword is used for cases where that distinction is necessary.

The protobuf definitions in this repo appear to be instead following proto2 conventions of indicating the optional keyword for any singular field.
@SanjayVas SanjayVas added the bug Something isn't working label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SanjayVas