Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Escape all values in HTML #98

Open
GHSam opened this issue Feb 21, 2021 · 1 comment
Open

Escape all values in HTML #98

GHSam opened this issue Feb 21, 2021 · 1 comment

Comments

@GHSam
Copy link
Contributor

GHSam commented Feb 21, 2021

I don't know if you want to but it might be worth having EJS escape all output just as a precaution to avoid any potential XSS issues.

The code looks safe but escaping all output would prevent any issues if some user input did accidentally sneak in. I can create a PR for it if you want to do it.

@BlairCurrey
Copy link
Collaborator

@GHSam you are talking about changing all instances of <%- to <%= correct? So <%- foo %> becomes <%= foo %>? I would merge such a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants