forked from cdm1263/javascript-calculator-7
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[문자열 덧셈 계산기] 이승준 미션 제출합니다. #591
Open
1eeSJ
wants to merge
16
commits into
woowacourse-precourse:main
Choose a base branch
from
1eeSJ:1eeSJ
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 132f04f - Browse repository at this point
Copy the full SHA 132f04fView commit details
Commits on Oct 21, 2024
-
test : 기본 구분자 사용에 관한 단위 테스트 작성
- 기본 구분자 쉼표 사용 - 기본 구분자 콜론 사용 - 기본 구분자 혼합 사용 에 대한 단위 테스트 작성
Configuration menu - View commit details
-
Copy full SHA for b302383 - Browse repository at this point
Copy the full SHA b302383View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6650ac - Browse repository at this point
Copy the full SHA e6650acView commit details -
- 입력값을 받는 readInput 함수 작성 - 결과를 출력하는 printResult 함수 작성
Configuration menu - View commit details
-
Copy full SHA for 35f6173 - Browse repository at this point
Copy the full SHA 35f6173View commit details -
- readInput 함수의 inputData 값 return - View 클래스의 export
Configuration menu - View commit details
-
Copy full SHA for 6ad9516 - Browse repository at this point
Copy the full SHA 6ad9516View commit details -
feat : Controller 클래스 작성 및 App.js의 일부 수정
- View를 이어줄 Controller 클래스 생성 - App에서 Controller의 객체 생성
Configuration menu - View commit details
-
Copy full SHA for 73079f3 - Browse repository at this point
Copy the full SHA 73079f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 297bb03 - Browse repository at this point
Copy the full SHA 297bb03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7871c76 - Browse repository at this point
Copy the full SHA 7871c76View commit details -
refactor : Calculator 클래스의 구조 변경 및, controller의 구조 변경
- calculate 계산 함수의 구분자와 숫자 분리를 utils 폴더의 separateNumber 함수로 분리 - Calculator에 inputData를 받는 setData함수 추가 - setData함수 추가에 따른 controller 구조 변경
Configuration menu - View commit details
-
Copy full SHA for 4c760d9 - Browse repository at this point
Copy the full SHA 4c760d9View commit details -
fix : Calculator 클래스 입력 오류 및 separateNumber함수 export 오류 수정
- 공백 입력 시 0이 출력되지 않고 오류 발생 부분 수정
Configuration menu - View commit details
-
Copy full SHA for 4b4c76a - Browse repository at this point
Copy the full SHA 4b4c76aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea8e51a - Browse repository at this point
Copy the full SHA ea8e51aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c455ee7 - Browse repository at this point
Copy the full SHA c455ee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca85e3f - Browse repository at this point
Copy the full SHA ca85e3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e5c2b - Browse repository at this point
Copy the full SHA 43e5c2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b256e4 - Browse repository at this point
Copy the full SHA 9b256e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2260b0 - Browse repository at this point
Copy the full SHA e2260b0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.