This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
style Mini Cart block as inline to remove the experimental features usage. #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -521 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
11 tasks
|
I agree with the conclusion that Mini Cart Block is an element to be used within Layout/Container Blocks that should be responsible for positioning and spacing of elements, could be group, row, columns or some absolute/fixed layers. If one day Gutenberg added context aware control for align/justify-self for when parent container/block supports it this would make sense but the way it was now I like the proposed approach more. |
I agree with you!
Yes! They are already working on this! |
gigitux
approved these changes
Mar 8, 2022
Aljullu
approved these changes
Mar 8, 2022
dinhtungdu
changed the title
tjcafferkey
added
the
type: enhancement
dinhtungdu
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5985 (comment), #5985 (review) and #5985 (comment), in this PR, I try to remove the usage of the experimental features:
inline-blockelement.The pros: simpler codebase, simpler styling.
The cons: Lack of alignments (which can be provided by a
<Group>or<Row>block).My take: I prefer this approach. The button is an inline element by its nature. The Mini Cart button is also 'likely' to be put inside a row.
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).