This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Price Filter block: enable global style #5559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Price Filter block: enable global style #4965
gigitux
added
type: enhancement
The issue is a request for an enhancement.
block: filter by price
Issues related to the Filter by Price block.
focus: global styles
Issues that involve styles/css/layout structure.
focus: FSE
Work related to prepare WooCommerce for FSE.
labels
Jan 13, 2022
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
January 13, 2022 16:58
Do you think it makes sense to add some comments about this hacky approach in the CSS? (maybe where I use |
gigitux
changed the title
Price Filter block: enable global style #4965
Price Filter block: enable global style
Jan 13, 2022
18 tasks
Size Change: +293 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
dinhtungdu
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it makes sense to add some comments about this hacky approach in the CSS?
Yes! I don't think that CSS is hacky. Having the child components inherit CSS from the parent is normal usage IMO.
Thanks for the review!
Anyway, I will merge the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: filter by price
Issues related to the Filter by Price block.
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: global styles
Issues that involve styles/css/layout structure.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for global style for the
Price Filter block
.Now, the user can edit the style for:
Note
Unfortunately at the current stage, global style API doesn't support the customization of the inner element instead of block wrapper, so this PR contains a hacky CSS for accomplishing the goal
WordPress/gutenberg#33255
WordPress/gutenberg#32417
#4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
WordPress 5.9
, install and enable theGutenberg
plugin.Twenty Twenty-Two
theme.Price Filter block
to a post.Reset
button from the different sections.Styles
icon on the right-top corner.Price Filter block
is shown under theBlocks
section. Personalize again the block.Changelog