Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Dynamic Properties when Using PHP 8.1.28 or Greater #26

Open
2 tasks done
ldr2273 opened this issue Jun 11, 2024 · 0 comments
Open
2 tasks done
Labels
type: bug The issue is a confirmed bug.

Comments

@ldr2273
Copy link

ldr2273 commented Jun 11, 2024

Describe the bug

When updating to PHP 8.1.28 or higher, deprecation notices regarding Dynamic Properties are displayed:

PHP Deprecated:  Creation of dynamic property Storefront_Product_Sharing::$plugin_url is deprecated in /srv/htdocs/wp-content/plugins/storefront-product-sharing/storefront-product-sharing.php on line 85
PHP Deprecated:  Creation of dynamic property Storefront_Product_Sharing::$plugin_path is deprecated in /srv/htdocs/wp-content/plugins/storefront-product-sharing/storefront-product-sharing.php on line 86

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and themes and confirmed this bug occurs when only WooCommerce + Storefront theme are active.
  • I can reproduce this bug consistently using the steps below.

To Reproduce

  1. Make sure debugging is true/enabled: https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/
  2. Ensure PHP version is 8.1.28 or higher
  3. Install and activate the plugin
  4. Check logs

Expected behavior

The plugin should be activated without any warnings.

Environment

WordPress 6.5.4
WooCommerce 8.9.3
PHP 8.2 (though it happens at 8.1.28 or higher)

Initially reported in 8254237-zen

@ldr2273 ldr2273 added the type: bug The issue is a confirmed bug. label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

1 participant