Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the get-plugin-releases action to use Node.js v20 #119

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

Part of #108

This PR upgrades the get-plugin-releases action to use Node.js v20.
In addition, it makes the action easier to develop and test.

Detailed test instructions:

  1. Test the action locally
    1. Use Node.js v20
    2. cd packages/github-actions
    3. npm install
    4. node --watch actions/get-plugin-releases/src/get-plugin-releases.js
    5. There should be no output because it's changed to only perform directly when running in GitHub Actions
    6. Edit the packages/github-actions/actions/get-plugin-releases/src/get-plugin-releases.js file and save it with the following test code at the end of the file
      getPluginReleases( {
      	slug: 'wordpress',
      	numberOfReleases: 10,
      	includeRC: false,
      	includePatches: false,
      } );
      
      getPluginReleases( {
      	slug: 'woocommerce',
      	numberOfReleases: 10,
      	includeRC: true,
      	includePatches: true,
      } );
    7. There should be corresponding outputs
      image
  2. View a previous workflow run used v1 action
  3. View a test workflow run used updated action
  4. View the versions output

@eason9487 eason9487 requested a review from a team April 25, 2024 07:09
@eason9487 eason9487 self-assigned this Apr 25, 2024
@eason9487 eason9487 mentioned this pull request Apr 25, 2024
26 tasks
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, they look good to me.

I can confirm I'm getting the correct results locally. Now that we use fetch directly I also don't see any flakey results being returned. The results from a previous run and a new run look good, and I can confirm the warnings are no longer present.

@eason9487 eason9487 merged commit 87914e7 into update/108-nodejs-v20 Apr 26, 2024
3 checks passed
@eason9487 eason9487 deleted the update/108-nodejs-v20-github-actions-get-plugin-releases branch April 26, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants