Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "using ${var} in strings is deprecated" notice #100

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix "using ${var} in strings is deprecated" notice #100

merged 1 commit into from
Apr 15, 2024

Conversation

rawdreeg
Copy link
Contributor

Changes proposed in this Pull Request:

Replace ${var} deprecated usage with sprintf

Closes #99.

Detailed test instructions:

  1. Try running ./bin/wr simulate for any repo and confirm no errors is shown.

@rawdreeg rawdreeg mentioned this pull request Apr 10, 2024
Merged
@rawdreeg rawdreeg requested a review from a team April 10, 2024 20:15
budzanowski
budzanowski approved these changes Apr 11, 2024
View reviewed changes
Copy link

@budzanowski budzanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the Variable Interpolation but this also works.

@rawdreeg
Copy link
Contributor Author

Thanks.

@rawdreeg rawdreeg merged commit 7ebb15c into trunk Apr 15, 2024
1 check passed
@rawdreeg rawdreeg deleted the fix/99 branch April 15, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budzanowski budzanowski budzanowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead
2 participants
@rawdreeg @budzanowski