Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open tasks for v1.0.0 #8

Closed
27 tasks done
dominiquesydow opened this issue Feb 24, 2021 · 5 comments
Closed
27 tasks done

Open tasks for v1.0.0 #8

dominiquesydow opened this issue Feb 24, 2021 · 5 comments
Assignees

Comments

@dominiquesydow
Copy link
Collaborator

dominiquesydow commented Feb 24, 2021

core infrastructure

Plots (static/interactive)

3D viz

  • Feature clouds by superfeature ID? At the moment, pml only contains H-123344123124 IDs - can we add H[1234, 1235, ...] to pml?
  • Check if dcd file has appropriate number of frames (e.g. 1000 frames) > For 20k frames this was not a problem in the Jupyter Notebook
  • Add interpolation to nglview trajectory > Added nglview.player.TrajectoryPlayer(view) to notebooks.
  • Add frame index to points in PML?
  • [Minor] Add pocket residue side chains: We do not have all pocket residues in PML/JSON output but we can add to each superfeature the environmental partners. Extend NGL dynophore visualization #28
  • [Major] Temporal resolution of dynophore clouds (use point frame index) - see Color clouds by frame #32

2D viz

CLI

  • Make dcd optional!
  • Add dynoviz demo

Package

  • Make package conda-installable (help from Jaime)
  • Make raise_keyerror_if_invalid_superfeature_name private!!

Documentation

@nadja-mansurov
Copy link

nadja-mansurov commented Mar 17, 2021

Hi @dominiquesydow

I have a question regarding

Interactive plots: Also select envpartners (depending on superfeature)?

Is it for 2d view? What tool are you going to use?
It looks like, that d3.js library could be imported to the notebook. It might be useful to create an interactive visualization of interaction

However, if it is only about plots, Altair looks better

@dominiquesydow
Copy link
Collaborator Author

Hi @nadja-mansurov,

The interactive plots are already in-place using ipywidgets (code).
Interactive plots are e.g. used in this notebook.

Unfortunately they not displayed in the website-rendered version, to see them you would need to run the notebook locally.

Here a screenshot:
image

I have a question regarding

Interactive plots: Also select envpartners (depending on superfeature)?

The idea was to add another widget that allows to select the environmental partners (rows) but they depend on the selected superfeatures and that becomes complex.

Instead, I was wondering if we offer widget for a percentage cutoff ("show only all env partners that appear more often than X% of the frames").

What do you think?

@dominiquesydow
Copy link
Collaborator Author

It looks like, that d3.js library could be imported to the notebook. It might be useful to create an interactive visualization of interaction

The d3.js import option for notebooks is amazing!

Do you think this could help us to add interaction partners to this 2D ligand view?

What I have is
image
(from dev notebook)

What I would like to add around the ligand are the env partners somehow like here:

image
(from my master thesis by hand)

@nadja-mansurov
Copy link

@dominiquesydow thank you for the quick response!
I guess it is possible to create a visualization like the one from your master thesis (thanks a lot for the link! :) )

I can imagine, that 2D visualization will be a "background" and env partners will be added by d3.
Another way is to create a visualization from scratch using a JSON file and d3.js.

I think I will create a separate branch from view-2d, and as the first step just add d3.js there

@dominiquesydow
Copy link
Collaborator Author

All features for a version 1.0.0 are implemented - moved a few more technical issues to #25. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants