Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

NTUtil macro factory slave issue with MacOS/Clang #67

Open
CJBuchel opened this issue Jan 10, 2022 · 6 comments
Open

NTUtil macro factory slave issue with MacOS/Clang #67

CJBuchel opened this issue Jan 10, 2022 · 6 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed wontfix This will not be worked on

Comments

@CJBuchel
Copy link
Member

Describe the bug
Bug occurs on the new 2022 update of gradlerio with assumed c++20 update with clang.
Clang has override issue see below.

/Users/cj/Desktop/code/WML/WML-Core/src/main/include/NTUtil/Slave.h:60:7: error: no viable overloaded '='
      __NTUTIL__SLAVE__METHOD_FACTORY__(std::vector<int>, BooleanArray)

To Reproduce
Steps to reproduce the behavior:

  1. Remove the #ifdef WML_PLATFORM_MACOS block (put there as a quick fix for mac platforms)
  2. Run code on mac platform (or azure)

Desktop (please complete the following information):

  • WML/GradleRIO Version: [GradleRIO 2022.1.1 | WML 2022.1.9-beta]
  • OS: [OSX 11]
@CJBuchel CJBuchel added the bug Something isn't working label Jan 10, 2022
@CJBuchel
Copy link
Member Author

p.s

The breaking code is on the 2022-update branch

CJBuchel added a commit that referenced this issue Jan 10, 2022
@CJBuchel CJBuchel changed the title NTUtil macro factory slave issue with Macos/Clang NTUtil macro factory slave issue with MacOS/Clang May 16, 2022
@CJBuchel
Copy link
Member Author

extra p.s
Breaking code is now on the master branch.
Fun times in production

@met4000
Copy link
Member

met4000 commented May 18, 2022

how is this still a fricking problem

@CJBuchel
Copy link
Member Author

CJBuchel commented May 18, 2022

Because technically it does not build on MacOS/with clang.
It's just mitigated using #ifdef so that when it's on platforms that use clang it doesn't build with it enabled. A bit like the NavX dummy system.

It doesn't pose much of an issue to anyone, and I've more or less considered it to be a wontfix. Just something that should be listed if some people are having issues.
Because it does mean that if they use the macro factory, building it won't be accurate and it might break on the rio.
So... up to you if you want to fix this or not.

@met4000 met4000 added help wanted Extra attention is needed wontfix This will not be worked on labels May 18, 2022
@met4000
Copy link
Member

met4000 commented May 18, 2022

If I get around to touching up wml I might look into it again, but would probably prioritise other bugs and actually properly doing the core re-write. Will leave this open and as wont-fix for now.

@CJBuchel
Copy link
Member Author

yep, pretty much what i thought. WML needs like... a 2.0.
Just completely rewrite the thing XD, every year is a pain to build quick fixes to solve the weird new WPI features and bugs
Like the new PDP and Compressor stuff was a real nightmare. I'm still finding new bugs with it to date

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants