From 87f7d1f56e2dc0e01f52108652b0a294aab98cc1 Mon Sep 17 00:00:00 2001 From: wkumler Date: Thu, 30 Nov 2023 13:20:40 -0800 Subject: [PATCH] Dropping MSnbase from DESCRIPTION I just can't pass checks with it. It requires netcdf which is a complicated install on Linux and it's not worth it for a few lines in the single vignette. --- .github/workflows/r-check-cran.yml | 5 ----- DESCRIPTION | 1 - 2 files changed, 6 deletions(-) diff --git a/.github/workflows/r-check-cran.yml b/.github/workflows/r-check-cran.yml index 94b1f8c..1c81485 100644 --- a/.github/workflows/r-check-cran.yml +++ b/.github/workflows/r-check-cran.yml @@ -62,9 +62,6 @@ jobs: do eval sudo $cmd done < <(Rscript -e 'writeLines(remotes::system_requirements("ubuntu", "20.04"))') - ## Force-install netcdf since it's missed by the system requirements - ## but required for mzR & MSnbase - sudo -s apt-get install -y libnetcdf-dev - name: Install BiocManager run: | @@ -74,8 +71,6 @@ jobs: - name: Install dependencies run: | install.packages("stringi") - BiocManager::install("ncdf4") - BiocManager::install("mzR") remotes::install_deps(dependencies = TRUE, repos=BiocManager::repositories()) remotes::install_cran("rcmdcheck") shell: Rscript {0} diff --git a/DESCRIPTION b/DESCRIPTION index 8267c7f..52f906e 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -39,7 +39,6 @@ Suggests: RSQLite, reticulate, BiocParallel, - MSnbase, Spectra, arrow, microbenchmark,