-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:vars converted to lowercase from camelCase via styles panel #1056
Comments
Hey @mnapthine , happy to see you'r trying codux and on stylable.io new-site branch 😎 I tried running the same scenario, but couldn't reproduce the issue:
then I tried several changes on the
All of the above changes should change the Are you doing anything different? |
Hey @idoros! Happy to be here. So I was messing around a bit more, it's actually not just via the panel but also when I hit the prettier button on the file, I assume prettier is run on save when using the panel. It reminds me of a very old Prettier issue. In VSCode our stylable files are formatted via stylable intelligence, I assume you guys built stylable intelligence for these type of issues as I remember we did struggle with prettier and stylable files many moons ago but had almost forgotten about it. I also noted that this happens for state selectors as well so if I open Can one choose to use the same formatting rules for stylable files within Codux that we use within VSCode or disable format on save for stylable files edited via the panel? Maybe I have some random config hidden away somewhere that is causing issues?? If you have any suggestions as to where I should look for stray/cached config then do let me know. Here is a little video that shows the issue. I have tried removing the project and re-adding to no avail. I can try reinstalling Codux (I have updated Version 15.22.0) but it feels like a issue with prettier and stylable files... For now I will avoid the Prettier button on 2024-03-13_11-40-54.mp4 |
I took a quick look at whats going on and from what I understand, Codux detects 2 potential formatters:
The quick solution to prevent prettier from formatting We'll explore ways of signaling when this happens and probably allow to configure defaults |
I was playing around with the stylable.io site just to see how things were setup there and playing with Codux in that project.
I noted that when changing a CSS value in the
theme.st.css
file via the styles panel that suddenly the styles of the Hero had changed. upon further inspection it appeared that the values had changed fromlightPrimary1: rgba(10, 16, 32, 0.81);
tolightprimary1: rgba(10, 16, 32, 0.81);
I was in the Hero component, selected
Button:callToAction
and I changed the color, then a whole host of visual changes happened due to the vars not being found.v15.21.0
The text was updated successfully, but these errors were encountered: