Skip to content

Latest commit

 

History

History
100 lines (64 loc) · 3.82 KB

CONTRIBUTING.md

File metadata and controls

100 lines (64 loc) · 3.82 KB
Raw

Contribution Guidelines

Hi! Thank you for taking the time to contribute to Armitjs!

In order to make the best use of both your time and that of the armitjs maintainers, please follow the guidelines in this document.

Branches

There are 3 important branches to know about:

  • master - the default branch
  • minor - a branch for commits which introduce new features which would go in the next SemVer minor release.
  • major - a branch for commits which introduce breaking changes which would go in the next SemVer major release.

Bug fixes should go direct in the master branch, from which new patch releases will be made regularly. Periodically the master branch will be merged into the minor and major branches.

Bug fixes

If you would like to contribute a bugfix, please first create an issue detailing the bug, and indicate that you intend to fix it. When creating commits, please follow the commit message format below.

New features

Again, please create a feature request detailing the functionality you intend to add, and state that you would like to implement it. When creating commits, please follow the commit message format below. New feature pull requests should be made against the minor branch.

When adding new public APIs to support your new feature, add a @since 1.2.0 tag (where "1.2.0" corresponds to what will be the next minor version) to the doc block. This will let readers of the documentation know the version in which the API was introduced. See the docs readme for more details on the valid docs tags.

/**
 * @description
 * Sets the value of the new API thing.
 *
 * @since 1.2.0
 */
myNewApi: number;

Commit message format

This repo uses Conventional Commits.

Simply use git cz or just cz instead of git commit when committing, installing the command line tool.

npm install -g commitizen


type(scope): Message in present tense

type may be one of:

  • feat (new feature)
  • fix (bug fix)
  • docs (changes to documentation)
  • perf (performance improvements)
  • style (formatting, missing semi colons, etc; no code change)
  • refactor (refactoring production code)
  • test (adding missing tests, refactoring tests; no production code change)
  • chore (updating build tasks etc; no production code change)

scope indicates the package affected by the commit:

  • common
  • core
  • create
  • etc.

If a commit affects more than one package, separate them with a comma:

fix(core,common): Fix the thing

If a commit applies to no particular package (e.g. a tooling change in the root package.json), the scope can be omitted.

Breaking Changes

If your contribution includes any breaking changes (including any changes to the DB schema; backwards-incompatible changes to the GraphQL APIs or VendureConfig; backwards-incompatible changes to current behavior), please include a BREAKING CHANGE section in your commit message as per the Conventional Commits specification.

Please also make your pull request against the major branch rather than master in the case of breaking changes.

Example:

feat(core): Add new field to Customer

Relates to #123. This commit adds the "foo" field to the Custom entity.

BREAKING CHANGE: A DB migration will be required in order to add the new "foo" field to the customer table.

Linting

Commit messages are linted on commit, so you'll know if your message is not quite right.

Setting up the dev environment

After cloning the artmit repo, please follow the Development guide in the README for instructions on how to get up and running locally.