Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

DraftJS v0.11.0 breaks plugin #181

Open
d3jawu opened this issue Aug 7, 2019 · 4 comments · May be fixed by #186
Open

DraftJS v0.11.0 breaks plugin #181

d3jawu opened this issue Aug 7, 2019 · 4 comments · May be fixed by #186

Comments

@d3jawu
Copy link

d3jawu commented Aug 7, 2019

When pairing the plugin with DraftJS v0.11.0, the console will give the error setEditorState is not a function anytime a Markdown shortcut is used.

Looks like there was an API change that may have affected this - I'm not familiar enough yet with DraftJS to know.

Using DraftJS v0.10.4 allows the plugin to work properly.

@elbakerino
Copy link

Just as an information, saw this issue during debugging.

I got the base repo runnning with 0.11 and opened a PR there. Maybe the change helps in this fork also.

@Arthur944
Copy link

I have the same issue too

1 similar comment
@ghost
Copy link

ghost commented Jan 30, 2020

I have the same issue too

@jakobo
Copy link

jakobo commented Feb 5, 2020

EDIT PR available at #186

There should probably be a peerDependency on DraftJS at ^0.10.5 similar to how we specify the plugin editor versions that are supported. However, fixing this (and supporting the new parameter in handleBeforeInput) will cause us to rev our peerDependency list; that'd be a bump to major and require folks to upgrade both DraftJS and the Plugin Wapper.

If you're blocked by this, make sure you're using draft-js @ ^0.10.5 and draft-js-plugins-editor @ ^2.1.1.

I'm all for 4.x of this plugin, but it's a small change with some pretty major implications. In the meanwhile, I'll put together a PR here on this fork that includes @elbakerino's changes + updates the peerDependencies. It will push us to 4.0.0 since these changes will be backwards incompatible with draft 0.10 and the 2.x branch of the plugins editor.

@mxstbr could you weigh on on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants