-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some problems #29
base: main
Are you sure you want to change the base?
Conversation
Antonio171003
commented
Jun 6, 2024
•
edited
Loading
edited
- Update React-Admin version to '4.14.4'.
- Fixed the filter functionality when the parameter is a reference.
- Fixed an Internal Server Error, Caused when attempting to filter by a column whose data type is not a string.
- Fixed : Failed prop type: Invalid prop on Reference Field.
- Fixed bugs related to image handling (saving and reading) and added a data provider to manage them.
Requires Reference Input instead of Reference Field.
… column whose data type is not a string.
…plied to `ReferenceFieldView`, expected a single ReactElement.
This reverts commit 112e1a5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should create many PR request as many features/bug fixes/etc, if we want to solve 4 issues then we should create 4 separated PR
There are many function that have undesirable empty spaces like:
def Test(): Boolean = {
// <- this type of spaces
1 == 1
// <- this type of spaces
}
Please remove them
There are many spaces that are missing between functions, like:
def Temp1(): Unit = {
...
} // <- add space here
def Temp2(): Unit = {
...
}
...-server/src/main/scala/net/wiringbits/spra/admin/repositories/DatabaseTablesRepository.scala
Outdated
Show resolved
Hide resolved
...-server/src/main/scala/net/wiringbits/spra/admin/repositories/DatabaseTablesRepository.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/DataProvider.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/DataProvider.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/package.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/DataProvider.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/reactadmin/ImageInput.scala
Show resolved
Hide resolved
...-server/src/main/scala/net/wiringbits/spra/admin/repositories/DatabaseTablesRepository.scala
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
spra-play-server/src/main/scala/net/wiringbits/spra/admin/utils/QueryBuilder.scala
Outdated
Show resolved
Hide resolved
spra-play-server/src/main/scala/net/wiringbits/spra/admin/models/FieldValue.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!