Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some problems #29

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

Antonio171003
Copy link
Contributor

@Antonio171003 Antonio171003 commented Jun 6, 2024

  • Update React-Admin version to '4.14.4'.
  • Fixed the filter functionality when the parameter is a reference.
  • Fixed an Internal Server Error, Caused when attempting to filter by a column whose data type is not a string.
  • Fixed : Failed prop type: Invalid prop on Reference Field.
  • Fixed bugs related to image handling (saving and reading) and added a data provider to manage them.

@Antonio171003 Antonio171003 changed the title Added all tables from data base and fixed some problems Fixed some problems Jun 6, 2024
Copy link
Contributor

@KapStorm KapStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create many PR request as many features/bug fixes/etc, if we want to solve 4 issues then we should create 4 separated PR

There are many function that have undesirable empty spaces like:

def Test(): Boolean = {
             // <- this type of spaces
  1 == 1
            // <- this type of spaces
}

Please remove them

There are many spaces that are missing between functions, like:

def Temp1(): Unit = {
  ...
}            // <- add space here
def Temp2(): Unit = {
  ...
}

Copy link
Contributor

@KapStorm KapStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants