Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Froala editor needs to be updated #810

Open
joseph-sm opened this issue Dec 20, 2022 · 1 comment
Open

Froala editor needs to be updated #810

joseph-sm opened this issue Dec 20, 2022 · 1 comment
Assignees
Labels
accepted Issues that have been accepted by the maintainers for inclusion third party Issues/PRs that are dependent on changes made to a third-party library

Comments

@joseph-sm
Copy link

joseph-sm commented Dec 20, 2022

Winter CMS Build

1.2

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

In the richtext formwidget when backspacing to delete a bullet point the bullet points get left behind, this is for both ordered and unordered lists.

winter-cms-froala-bug

This is an old issue in froala editor that was fixed back in 2018.

Steps to replicate

  1. In the backend go to content pages.
  2. Create a new page or edit an existing one.
  3. Create or edit an list (ordered or unordered)
  4. At the end of one of the list items use the backspace (delete) key to remove the list item.

You will notice that the bullet point is not removed.

Expected behaviour

In the current version of froala editor the bullet points are removed.

winter-cms-froala-bug1

Workaround

Clicking back on the line with the empty bullet point and hit backspace will delete it.

@joseph-sm joseph-sm added needs review Issues/PRs that require a review from a maintainer Type: Unconfirmed Bug labels Dec 20, 2022
@LukeTowers LukeTowers changed the title [modules/backend/formwidgets] Richeditor bulletpoint backspace issue Froala editor needs to be updated Dec 20, 2022
@LukeTowers LukeTowers added Type: Bug third party Issues/PRs that are dependent on changes made to a third-party library accepted Issues that have been accepted by the maintainers for inclusion and removed Type: Unconfirmed Bug needs review Issues/PRs that require a review from a maintainer labels Dec 20, 2022
@LukeTowers LukeTowers self-assigned this Dec 20, 2022
@LukeTowers LukeTowers moved this to In Development in Roadmap May 30, 2023
@github-actions
Copy link

This issue will be closed and archived in 3 days, as there has been no activity in this issue for the last 6 months.
If this issue is still relevant or you would like to see it actioned, please respond within 3 days.
If this issue is critical for your business, please reach out to us at [email protected].

@github-actions github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Jun 21, 2023
@bennothommo bennothommo added Status: In Progress and removed stale Issues/PRs that have had no activity and may be archived labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issues that have been accepted by the maintainers for inclusion third party Issues/PRs that are dependent on changes made to a third-party library
Projects
Status: In Development
Development

No branches or pull requests

3 participants