Fix: Update composer scripts and tailwind dependencies #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before install and set the devDependencies for tailwind
|
@nialma per this comment, I don't think we should rollback the |
|
@bennothommo The problem I see with the fully automatic installation is that there are different database types that differentiate database names and sometimes the users.....Therefore, I currently see the effort as being too great to fully automate the installation..... I'm currently working on ensuring that when you create a Tailwind theme via the backend, mix is automatically installed and configured... First of all without alpinejs... that comes afterwards.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winter CMS Build
dev-develop
PHP Version
8.2.24
Database engine
MySQL/MariaDB
Plugins installed
No response
System
Windows 11
### This PR fixes issue #1242 and replaces the deleted PR #1241.
Changes:
composer.json:
modules/cms/console/scaffold/theme/tailwind/package.stub:
The main benefit is that the installation process now stops at the right moment, allowing for proper key generation before continuing with the installation.
Related: