Allow named key Lists for patterns

[woldtwerk]

Hi Christian,
currently it is not possible to use pattern lists with named keys.

e.g. for putting patterns inside the page.header, page.footer variables.

page:
  use: "@namespace/layout/page.html.twig"
  namespace: "Layout"
  label: Page
  description: Page
  fields:
    page:
      type: pattern
      label: Page
      description: The Page
      preview:
        header:
          id: 'header'
        footer:
          id: 'footer'

I didn't see any problem for allowing this.

Relevant code is:

wingsuit/packages/pattern/src/twigRenderEngine.ts

Line 95 in 68dfedb

const delta: number = Number.parseInt(nameKeys[1], 10);

delta is cast to a number here. this would have to allow strings also

wingsuit/packages/pattern/src/twigRenderEngine.ts

Line 98 in 68dfedb

previewRenderedVariables[nameKeys[0]] = [];

previewRenderedVariables is initialised with an empty array. This would need to be an object if delta is a string.

Add object check in

wingsuit/packages/pattern/src/PatternVariant.ts

Line 151 in 68dfedb

} else if (field.getType() === 'pattern' && preview?.id) {

else if (field.getType() === 'pattern' && typeof preview === 'object') {
        Object.keys(preview).forEach(i => {
          previewPatterns["".concat(key, "--").concat(i)] = _this2.buildPreviewPattern(preview[i]);
        })

This would allow to print {{ page.header }} in templates, but not {{ page }}. Is that good enough?

If that seems alright to you I'd like to create a pull request.

[christianwiedemann]

Hi, sorry for late answer. Somehow missed your ticket. Technical is it not a problem. But you can't use it in Drupal this. So if you use inside your pattern it would not work in drupal.