You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
From time to time we are creating pieces of a component (e.g. atoms/molecules etc.), whose root component (e.g. organism) has a dark background color, thus the atom or molecule itself mainly uses light text colors. In that case it is difficult to check the isolated atom/molecule, because storybook has a light background/story canvas as a default behavior.
Describe the solution you'd like
It would be great to have the ability to change the background of a story in both, the canvas and doc mode on a variant basis. With minor changes I got it already working with the help of the themes plugin, but only for a whole story with all of its variants.
Things I tried so far:
The following config seems to be deprecated (see here):
However doing it that way, it seems to be impossible to grab only a specific variant of the component. So the real question is how to add parameters to specific variants only, instead to all of them via the stories.jsx file.
Another disadvantage is that the method described above only changes background of a whole story in canvas mode. When looking at the story in docs mode, the background is still white. A workaround is to target the specific story id by css and change its background for docmode manually by adjusting the preview-head.html, e.g.:
However this feels rather like a hacky workaround than a real solution. Maybe it would be possible to add the background color on the fly with javascript when rendering the docs of a specific story/variant like the storybook background plugin tries to do see here
Describe alternatives you've considered
Like mentioned above there is also the official background addon (see here) and it seems they've solved the exact same problem with docmode (here) in storybook 6.1. Maybe exchanging the theme plugin with the background plugin could save us time. This would only solve the docmode problem and we'd still need to come up with a solution for adding parameters on a variant basis.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
From time to time we are creating pieces of a component (e.g. atoms/molecules etc.), whose root component (e.g. organism) has a dark background color, thus the atom or molecule itself mainly uses light text colors. In that case it is difficult to check the isolated atom/molecule, because storybook has a light background/story canvas as a default behavior.
Describe the solution you'd like
It would be great to have the ability to change the background of a story in both, the canvas and doc mode on a variant basis. With minor changes I got it already working with the help of the themes plugin, but only for a whole story with all of its variants.
Things I tried so far:
The following config seems to be deprecated (see here):
wingsuit/starter-kits/tailwind/apps/storybook/preview.js
Lines 8 to 12 in d239d7d
After that I was able to change the canvas of a whole component by adjusting its correspondending stories.jsx file e.g.:
However doing it that way, it seems to be impossible to grab only a specific variant of the component. So the real question is how to add parameters to specific variants only, instead to all of them via the stories.jsx file.
Another disadvantage is that the method described above only changes background of a whole story in canvas mode. When looking at the story in docs mode, the background is still white. A workaround is to target the specific story id by css and change its background for docmode manually by adjusting the preview-head.html, e.g.:
However this feels rather like a hacky workaround than a real solution. Maybe it would be possible to add the background color on the fly with javascript when rendering the docs of a specific story/variant like the storybook background plugin tries to do see here
Describe alternatives you've considered
Like mentioned above there is also the official background addon (see here) and it seems they've solved the exact same problem with docmode (here) in storybook 6.1. Maybe exchanging the theme plugin with the background plugin could save us time. This would only solve the docmode problem and we'd still need to come up with a solution for adding parameters on a variant basis.
The text was updated successfully, but these errors were encountered: