Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: Include NodesFile in RaftDir #106

Closed
ohkinozomu opened this issue Aug 1, 2024 · 1 comment · Fixed by #107
Closed

proposal: Include NodesFile in RaftDir #106

ohkinozomu opened this issue Aug 1, 2024 · 1 comment · Fixed by #107

Comments

@ohkinozomu
Copy link
Contributor

I am not yet very familiar with comqtt, but the NodesFile seems to be an important persistent file.
Should we include it in the RaftDir?
This is important for platforms like Kubernetes, where files are generally ephemeral.
@ohkinozomu ohkinozomu mentioned this issue Aug 1, 2024
Merged
@ohkinozomu
Copy link
Contributor Author

Closing due to this comment:
#107 (comment)

NodesFile is used to assist memberlist to discover nodes, and PeersFile is used to assist Raft to discover peers.
RaftDir stores all the data generated during raft running, so there is no need to put NodesFile in the RaftDir directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add nodes-file-dir configuration ohkinozomu/comqtt
1 participant
@ohkinozomu