Text is not returned back after some time

[tagwint]

I've been happily used this extension for a quite long time.
Since recently, an annoying issue started happening:
16 seconds later after you put text to the external editor, it does not return back to input regardless modified or not when you close the editor. No errors, input background remains colored. So you only can manage using the extension if your edit session is less than 16 seconds.
Lately Used:
Google chrome Version 74.0.3729.169 (Official Build) (64-bit)
editserver.psgi https://gist.github.com/frodwith/367752
I tried clean Google-chrome instance with sole emacs-edit-chrome extension installed as unpacked in dev mode.
OS: Fedora 29 x86_64

Note except for browser update nothing has been changed since i started using the extension, so i guess it is somehow connected withe the browser version.
I'll try some older version meanwhile to confirm that

UPDATE: Indeed, the issue started with version 74 of the browser
Something from this list to be blamed:
https://chromium.googlesource.com/chromium/src/+log/73.0.3683.74..74.0.3729.108

Any other clue will be appreciated.

[willmoffat]

Thanks for the bug report! Adding my own notes here too.

To reproduce:

• Open https://robertnyman.com/html5/forms/input-types.html
• Click in an input element
• Right-click and select 'Emacs Edit'
• Keep emacs editor frame open for more than 16s.
• Inspect the background page, observe:
  • Network request to emacs completed successfully. Response contains new content.
  • Console error: Cannot access contents of the page. Extension manifest must request permission to access the respective host.

[willmoffat]

@tagwint Can you pull the latest master and see if it works now?

[tagwint]

I am sorry for late reply.
I have not expected a quick reply after seeing the last commit date back in 2016 :)
Have been using Google-Chrome downgraded to v73 meanwhile.

Tried the latest master and played with it a little.
Out of around 20 attempts one failed.
The failed session was not much longer that 16 actually.

Besides, noticed my shortcut I bound 'Edit emacs' stopped working, so now it is only
popup menu and toolbar I can use to call editor.
The shortcut is the one defined in manifest.json.
I customized it to Alt-M instead of default Ctrl+Shift+E and it used to work before.
Should that be a separate issue to open? Please advise, will not rise that before you reply.
Another customization I made is the port number in the EMACS_EDIT_SERVICE

Many thanks for your effort!

UPD: Played more meanwhile, no more failures could be reproduced.
UPD2: Used Google-Chrome 74 for tests, will try another workstation, inform you later then

[tagwint]

Hi again, and here's my summary after using the master changes -

1. I've managed to restore shortcut bound to call the extension - so it is not a problem anymore
2. Originally raised issue - not returning text if keeping session longer than 16 sec - is still there for every first usage of the editor on a new chrome tab. So one have to "shake it up" before using :)

[willmoffat]

Thanks for the updated report. I'll try and find some time to look into it. Very bizarre!