Added a httponly option for HTMLResponse.set_cookie #876
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #799, I added an option configurable through an environment variable
SOLARA_SESSION_HTTP_ONLY
, and passing this to thehttponly
option in HTMLResponse.As discussed, this change is backwards compatible because it defaults to False.
Here we can verify the httpOnly attribute of the
solara-session-id
cookie using Developer tools:and here's another screenshot showing the behavior when setting the environment variable
SOLARA_SESSION_HTTP_ONLY=True
:Note that the cookie no longer appears in
document.cookie
.Thus, this PR makes it possible for a solara-based application to comply with cwe 402