Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: a no dependencies option for embed_html with offline=True #199

Open
GenevieveBuckley opened this issue Nov 1, 2018 · 2 comments

Comments

@GenevieveBuckley
Copy link
Contributor

Feature request for a no dependencies option for embed_html with offline=True.

As discussed here: #192 (comment)

I was wondering if it would be of general use to have a no dependencies option for the offline html? It'd be useful in situations where you write many html files to the same location, and care about how fast you can write them to disk.
(This is something we're doing at the moment, overwriting a single file with new data, and I think it'd speed up the responsiveness quite a bit if it didn't re-download every dependency each time.)

@maartenbreddels commented
Yes, a cache would be nice, I think though it should (optionally) check the CDN for the right version, and if not it should update it. My guess is that the request package can do this. I also hate that it downloads everything every time. It can also do a hardlink to the cached file (for non-windows users).

@maartenbreddels
Copy link
Collaborator

Hi Genevieve,

That is what offline=True should do right, or do you mean with the no dependencies option to use the cache? Do you think using the cache should be op in?

cheers,

Maarten

@GenevieveBuckley
Copy link
Contributor Author

Sorry, I think I misunderstand. From the code in embed.py it doesn't look like it checks whether the necessary files already exist, it just writes them every time to a folder called js next to the output html. I do think using cached/existing dependencies should be the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants