Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature failure against Ruby head #494

Open
faisal opened this issue Jun 7, 2024 · 1 comment
Open

feature failure against Ruby head #494

faisal opened this issue Jun 7, 2024 · 1 comment

Comments

@faisal
Copy link
Contributor

faisal commented Jun 7, 2024

#492 and #493 both fail in the same place when testing against HEAD:

expected `rubycritic --version  --no-browser` to have output "RubyCritic 4.9.1\n"
but was:
   RubyCritic 4.9.1

   /home/runner/work/rubycritic/rubycritic/vendor/bundle/ruby/3.4.0+0/gems/childprocess-5.0.0/lib/childprocess.rb:7: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.
Diff:
@@ -1,3 +1,5 @@
 RubyCritic 4.9.1
+

This feature is not related to any codepaths touched by the PRs (particularly the case of #493, which touched no code paths).

@faisal
Copy link
Contributor Author

faisal commented Jun 7, 2024

This reproduces locally. The feature patch is trivial but I'm trying to figure out why the behavior changed against HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant