Loosen dependency version requirements

[faisal]

From #482:

The looser this gem is in terms of versioning the dependencies, the easier it is for projects to bundle it in.

At present, 23 of the 28 dependencies in rubycritic.gemspec have version restrictions. Are they all needed?

[brkn]

Just to give an anecdata.

I never add this gem into the gemfile, and those restrictions helps when I do gem install rubycritic

[faisal]

Ruby 3 is deprecated, so here's a fork that jumps rubycritic's minimum version to 3.1: https://github.com/faisal/rubycritic/tree/ruby_31

And here's one that also gets rid of almost all version requirements in the gemspec: https://github.com/faisal/rubycritic/tree/ruby_31_loose

Right now they produce the same bundles. I'm curious how much that will continue to be true as dependency gems update.

[faisal]

Just to give an anecdata.

I never add this gem into the gemfile, and those restrictions helps when I do gem install rubycritic

In what way do they help?

[brkn]

I meant that they are needed in ruby2.7 context. But I guess since v4.9.1 is already the latest version supporting the ruby2.7, maybe this doesn't matter for further releases? Apologies for confusion.

To demonstrate how it was before v4.9.1, this was the behaviour

❯ ruby -v
ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [arm64-darwin22]

❯ gem install rubycritic -v 4.9.0   
Fetching flay-2.13.2.gem
Fetching rubycritic-4.9.0.gem
ERROR:  Error installing rubycritic:
        The last version of reek (~> 6.0, < 7.0) to support your Ruby & RubyGems was 6.1.4. Try installing it with `gem install reek -v 6.1.4` and then running the current command again
        reek requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.225.

After v4.9.1, the restrictions made gem install smooth.

[aseroff]

FWIW, I had to pin to 4.9.0 because 4.9.1 sent my rubocop several versions behind edge.