Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest_orch_frequency doesn't work well for months #114

Open
whipson opened this issue Aug 28, 2024 · 0 comments
Open

suggest_orch_frequency doesn't work well for months #114

whipson opened this issue Aug 28, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@whipson
Copy link
Owner

whipson commented Aug 28, 2024

If true best orchestrator frequency is a monthly interval (e.g., 1 month, 3 months) suggest_orch_frequency will present this in terms of days (e.g., 31 days, 93 days). This is because we're using a single representation of the number of seconds for a month and not accounting for the fact that months have different amounts of seconds.

This would result in a gradual drifting of the scheduled pipelines.

library(maestro)

test_schedule <- data.frame(
  frequency = c("5 months", "1 quarter"),
  frequency_n = c(5, 1),
  frequency_unit = c("months", "quarter"),
  start_time = as.POSIXct("2024-05-20")
)

suggest_orch_frequency(test_schedule)

#> "31 days"
@whipson whipson added the bug Something isn't working label Aug 28, 2024
@whipson whipson self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant