From 856b409d0269bfa334ae5c098bd254e87f10d680 Mon Sep 17 00:00:00 2001 From: Anne van Kesteren Date: Sat, 8 Jun 2024 08:36:01 +0200 Subject: [PATCH] Stop calling parse a CSS with OffscreenCanvas Also modernize the way we handle shadowColor. Closes #10398. --- source | 65 ++++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 41 insertions(+), 24 deletions(-) diff --git a/source b/source index a15686071d8..93cd30be618 100644 --- a/source +++ b/source @@ -65118,8 +65118,9 @@ context.fillRect(100,0,50,50); // only this square remains fill style, stroke style, filter, global alpha, and compositing and blending operator.

+ data-x="concept-canvas-global-alpha">global alpha, compositing and blending operator, and shadow color.

  • The current values of the following attributes: lineWidth, data-x="dom-context-2d-shadowOffsetX">shadowOffsetX, shadowOffsetY, shadowBlur, shadowColor, font, textAlign, textBaseline, If the given value is a string, then:

      +

    1. Let context be this's canvas attribute's value, if that is an element; + otherwise null.

      2. +

    2. Let parsedValue be the result of parsing the given value with this's canvas attribute's value.

      3. + value">parsing the given value with context if non-null.

    3. If parsedValue is failure, then return.

      4. @@ -67778,9 +67781,12 @@ try {

      If the given value is a string, then:

        +

      1. Let context be this's canvas attribute's value, if that is an element; + otherwise null.

        2. +

      2. Let parsedValue be the result of parsing the given value with this's canvas attribute's value.

        3. + value">parsing the given value with context if non-null.

      3. If parsedValue is failure, then return.

        4. @@ -69684,20 +69690,30 @@ console.log(pixels.data[2]);
        +

        Objects which implement the CanvasShadowStyles interface have an associated shadow color, which is a CSS color. + Initially, it must be transparent black.

        +

        The shadowColor attribute sets the color of the - shadow.

        + data-x="dom-context-2d-shadowColor">shadowColor         getter steps are to return the serialization of this's shadow color.

        + +

        The shadowColor setter steps are:

        + +
          +

        1. Let context be this's canvas attribute's value, if that is an element; otherwise + null.

          2. -

          When the context is created, the shadowColor - attribute initially must be transparent black.

          +

        2. Let parsedValue be the result of parsing the given value with context if non-null.

          3. -

          On getting, the serialization of the color - must be returned.

          +

        3. If parsedValue is failure, then return.

          4. -

          On setting, the new value must be parsed - with this canvas element and the color assigned. If parsing the value results in - failure then it must be ignored, and the attribute must retain its previous value. - CSSCOLOR

          +

        4. Set this's shadow + color to parsedValue.

          5. +

        The shadowOffsetX and

        Shadows are only drawn if the opacity component of - the alpha component of the color of shadowColor is - nonzero and either the shadowBlur is nonzero, or - the shadowOffsetX is nonzero, or the shadowOffsetY is nonzero.

        + the alpha component of the shadow + color is nonzero and either the shadowBlur + is nonzero, or the shadowOffsetX is nonzero, or + the shadowOffsetY is nonzero.

        When shadows are drawn, they must be rendered as follows:

        @@ -69761,11 +69777,12 @@ console.log(pixels.data[2]);

      4. Set the red, green, and blue components of every pixel in B to the - red, green, and blue components (respectively) of the color of shadowColor.

        5. + red, green, and blue components (respectively) of the shadow color.

      5. Multiply the alpha component of every pixel in B by the alpha - component of the color of shadowColor.

        6. + component of the shadow + color.

      6. The shadow is in the bitmap B, and is rendered as part of the drawing model described below.