Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Emit events as the finality checker performs its checks #6

Open
aaroncox opened this issue Apr 12, 2023 · 2 comments
Open

Idea: Emit events as the finality checker performs its checks #6

aaroncox opened this issue Apr 12, 2023 · 2 comments

Comments

@aaroncox
Copy link
Member

aaroncox commented Apr 12, 2023

Got a recommendation today that it'd be nice if this finality "monitor" (or whatever we're calling this one) could somehow emit events to the frontend related to finality, so that the app could then handle those results in their own UI.

I don't know the structure of how we relay these events back to the app, but I imagine every time we call get_transaction_status we can relay that info back to the app. Then when the finality threshold is reached, we call the callback like it does now.

@dafuga
Copy link
Contributor

dafuga commented Apr 12, 2023

Yeah, that would be cool. Maybe the FE can pass an updateCallback function as a parameter when initializing the package?

@dafuga
Copy link
Contributor

dafuga commented Apr 12, 2023

And maybe that should be a parameter in the transact-plugin-finality-callback plugin instead of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants